On Wed, 2010-11-17 at 10:23 +0800, ext Bryan Wu wrote:
> Generic DPI panel driver includes the driver and 4 similar panel configurations. It
> will match the panel name which is passed from platform data and setup the
> right configurations.
>
> With generic DPI panel driver, we can remove those 4 duplicated panel display
> drivers. In the future, it is simple for us just add new panel configuration
> date in panel-generic-dpi.c to support new display panel.
>
> Signed-off-by: Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
> ---
> .../arm/plat-omap/include/plat/panel-generic-dpi.h | 37 ++
> drivers/video/omap2/displays/Kconfig | 8 +
> drivers/video/omap2/displays/Makefile | 1 +
> drivers/video/omap2/displays/panel-generic-dpi.c | 348 ++++++++++++++++++++
> 4 files changed, 394 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
> create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c
>
<snip>
> +static int generic_dpi_panel_probe(struct omap_dss_device *dssdev)
> +{
> + struct panel_generic_dpi_data *panel_data = get_panel_data(dssdev);
> + struct panel_config *panel_config = NULL;
> + struct panel_drv_data *drv_data = NULL;
> + int i;
> +
> + dev_dbg(&dssdev->dev, "probe\n");
> +
> + if (!panel_data || !panel_data->name)
> + return -EINVAL;
> +
> + for (i = 0; i < ARRAY_SIZE(generic_dpi_panels); i++) {
> + if (strcmp(panel_data->name, generic_dpi_panels[i].name) == 0) {
> + panel_config = &generic_dpi_panels[i];
> + break;
> + }
> + }
> +
> + if (!panel_config)
> + return -EINVAL;
> +
> + dssdev->panel.config = panel_config->config;
> + dssdev->panel.timings = panel_config->timings;
> + dssdev->panel.acb = panel_config->acb;
> + dssdev->panel.acbi = panel_config->acbi;
> +
> + drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
> + if (!drv_data)
> + return -ENOMEM;
> +
> + drv_data->dssdev = dssdev;
> + drv_data->panel_config = panel_config;
> +
> + dev_set_drvdata(&dssdev->dev, drv_data);
> +
> + return 0;
> +}
> +
> +static void generic_dpi_panel_remove(struct omap_dss_device *dssdev)
> +{
> +}
You need to free the drv_data here.
Perhaps this will be the last fix =).
Tomi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
