* Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [101116 08:06]: > Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> writes: > > > On Tue, 16 Nov 2010 09:23:06 -0600 > > Nishanth Menon <nm@xxxxxx> wrote: > > > >> my initial implementation had forced board files to call the > >> opp_init_table, then changed that here: > >> http://marc.info/?l=linux-omap&m=127431810922704&w=2 > >> Kevin seemed happy with the change here: > >> http://marc.info/?l=linux-omap&m=127507237109393&w=2 > > > > Ok, if Kevin is happy with this solution, fair enough. Sorry for the > > noise, and thanks for your answers. > > Yes, I'm not a big fan of the init function called multiple times > either, but I really want to minimize what board files have to do. > > Historically, we tend to add all the init functions to every board file, > and this is getting cumbersome to understand and maintain. What we need > is for common code to take care of sensible defaults for all boards, and > then only boards with non-default behavior have to have custom code. Yeah. The initial comment from Thomas with data in .h file should be fixed though. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
