Hello, On Mon, 15 Nov 2010 13:27:39 -0600 Nishanth Menon <nm@xxxxxx> wrote: > +++ b/arch/arm/mach-omap2/opp3xxx_data.h > + > +static struct omap_opp_def __initdata omap34xx_opp_def_list[] = { > + > +static struct omap_opp_def __initdata omap36xx_opp_def_list[] = { Do we really want to have structure definitions in an header file ? Unless I'm wrong, this means that if the opp3xxx_data.h file is included in two different C files, the structures will be present twice. As far as I could see, most of the kernel instantiate structure in C files instead. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html