>>-----Original Message----- >>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >>Sent: Thursday, November 11, 2010 6:19 AM >>To: Gopinath, Thara >>Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; Cousson, Benoit; Sripathy, >>Vishwanath; Sawant, Anand >>Subject: Re: [PATCH v2 04/14] OMAP: Introduce API to register a device with a >>voltagedomain >> >>Thara Gopinath <thara@xxxxxx> writes: >> >>> This patch adds an API in the voltage layer that >>> can be used during omap_device_build to register the built >>> device with the voltage domain. This API is to be typically called >>> only once per device during the device registeration. This approach >>> makes it easy during dvfs to scale all the devices associated with >>> a voltage domain and then scale the voltage domain. >>> >>> Signed-off-by: Thara Gopinath <thara@xxxxxx> >> >>[...] >> >>> /* Generic voltage init functions */ >>> @@ -1240,6 +1251,40 @@ int omap_voltage_add_request(struct voltagedomain >>*voltdm, struct device *dev, >>> return 0; >>> } >>> >>> +int omap_voltage_add_dev(struct voltagedomain *voltdm, struct device *dev) >> >>minor nit: I prefer this be a 'register' function, >>e.g. omap_voltage_register (or _register_dev) _register_dev. Will rename. >> >>[...] >> >>> diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat- >>omap/omap_device.c >>> index abe933c..7c902a6 100644 >>> --- a/arch/arm/plat-omap/omap_device.c >>> +++ b/arch/arm/plat-omap/omap_device.c >>> @@ -86,6 +86,7 @@ >>> >>> #include <plat/omap_device.h> >>> #include <plat/omap_hwmod.h> >>> +#include <plat/voltage.h> >>> >>> /* These parameters are passed to _omap_device_{de,}activate() */ >>> #define USE_WAKEUP_LAT 0 >>> @@ -453,6 +454,17 @@ struct omap_device *omap_device_build_ss(const char >>*pdev_name, int pdev_id, >>> for (i = 0; i < oh_cnt; i++) { >>> hwmods[i]->od = od; >>> _add_optional_clock_alias(od, hwmods[i]); >>> + if (hwmods[i]->vdd_name) { >> >>Use: >> >> if (!is_early_device && hwmods[i]->vdd_name) >> >>> + struct omap_hwmod *oh = hwmods[i]; >>> + struct voltagedomain *voltdm; >>> + >>> + if (is_early_device) >>> + continue; >> >>and drop this check Ok >> >> >>> + voltdm = omap_voltage_domain_lookup(oh->vdd_name); >>> + if (!omap_voltage_add_dev(voltdm, &od->pdev.dev)) >>> + oh->voltdm = voltdm; >>> + } >>> } >>> >>> if (ret) >> >>Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
