Hi, >> -----Original Message----- >> From: Andrei Emeltchenko [mailto:andrei.emeltchenko.news@xxxxxxxxx] >> Sent: Friday, November 12, 2010 6:50 PM >> To: G, Manjunath Kondaiah >> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> linux-arm@xxxxxxxxxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx >> Subject: Re: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates >> >> On Fri, Nov 12, 2010 at 3:17 PM, G, Manjunath Kondaiah >> <manjugk@xxxxxx> wrote: >> > >> > >> >> -----Original Message----- >> >> From: linux-omap-owner@xxxxxxxxxxxxxxx >> >> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of >> >> Emeltchenko Andrei >> >> Sent: Friday, November 12, 2010 6:34 PM >> >> To: linux-omap@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> >> linux-arm@xxxxxxxxxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx >> >> Subject: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates >> > >> > s/diplicates/duplicates >> > >> >> >> >> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> >> >> >> >> Add MDR1 Serial register definition to serial_reg and remove >> >> duplicated >> >> code, remove magic MDR1 register numbers from serial drivers. >> >> >> >> *v2 add OMAP keyword to MDR1 definition >> >> *v3 remove magic from serial drivers >> >> *v4 taking comments from Manjunath and Govindraj: typos, CC >> >> >> >> Andrei Emeltchenko (4): >> >> OMAP: Serial: Define OMAP uart MDR1 register definitions >> >> OMAP1: Serial: remove magic numbers for MDR1 reg >> >> OMAP2: Serial: remove magic numbers for MDR1 reg >> >> OMAP: Serial: remove redefined MDR1 register definitions >> >> >> >> arch/arm/mach-omap1/serial.c | 6 ++++-- >> >> arch/arm/mach-omap2/serial.c | 15 >> +++++++++------ >> >> arch/arm/plat-omap/include/plat/omap-serial.h | 3 --- >> >> drivers/serial/omap-serial.c | 6 +++--- >> >> include/linux/serial_reg.h | 12 ++++++++++++ >> >> 5 files changed, 28 insertions(+), 14 deletions(-) >> > >> > Do you think patch series is required for these changes? How about >> > merging with single patch? >> >> I can merge, sometimes somebody need patches to be split, > > why? can you give example? Maybe I got it wrong. > Please read: http://lwn.net/Articles/139918/ > "if you make a single change to numerous files, group those changes into > a single patch. Thus a single logical change is contained within a > single patch." I have squashed those patches to the single one. Regards, Andrei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
