Re: [RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/11/2010 5:35 PM, Tony Lindgren wrote:
* Benoit Cousson<b-cousson@xxxxxx>  [101019 15:14]:
--- a/arch/arm/mach-omap2/mux.h
+++ b/arch/arm/mach-omap2/mux.h
+
+/**
+ * struct mux_partition - contain partition related information
+ * @name: name of the current partition
+ * @flags: flags specific to this partition
+ * @phys: physical address
+ * @size: partition size
+ * @base: virtual address after ioremap
+ * @muxmodes: list of nodes that belong to a partition
+ * @node: list node for the partitions linked list
+ */
+struct omap_mux_partition {
+	const char		*name;
+	u32			flags;
+	u32			phys;
+	u32			size;
+	void __iomem		*base;
+	struct list_head	muxmodes;
+	struct list_head	node;
+};

With the omap_mux_parition..

  /**
   * struct omap_mux - data for omap mux register offset and it's value
   * @reg_offset:	mux register offset from the mux base
   * @gpio:	GPIO number
+ * @id:		Partition identifier
   * @muxnames:	available signal modes for a ball
   */
  struct omap_mux {
@@ -82,6 +114,7 @@ struct omap_mux {
  	char	*muxnames[OMAP_MUX_NR_MODES];
  #ifdef CONFIG_DEBUG_FS
  	char	*balls[OMAP_MUX_NR_SIDES];
+	struct omap_mux_partition *partition;
  #endif
  #endif
  };
@@ -89,6 +122,7 @@ struct omap_mux {
  /**
   * struct omap_ball - data for balls on omap package
   * @reg_offset:	mux register offset from the mux base
+ * @id:		Partition identifier
   * @balls:	available balls on the package
   */
  struct omap_ball {
@@ -100,6 +134,7 @@ struct omap_ball {
   * struct omap_board_mux - data for initializing mux registers
   * @reg_offset:	mux register offset from the mux base
   * @mux_value:	desired mux value to set
+ * @id:		Partition identifier
   */
  struct omap_board_mux {
  	u16	reg_offset;

..I think the above changes are no longer needed.

Oops yep, I forgot to remove the @id in the kerneldoc.
I was about to send the next revision, maybe I should wait a little bit more.

Thanks,
Benoit

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux