> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, November 10, 2010 9:56 PM > To: G, Manjunath Kondaiah > Cc: linux-omap@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Peter Ujfalusi; > Cousson, Benoit; Shilimkar, Santosh > Subject: Re: [PATCH v3 02/13] OMAP: DMA: Introduce errata > handling feature > > "G, Manjunath Kondaiah" <manjugk@xxxxxx> writes: > > [...] > > >> > + if (omap_type() == OMAP3430_REV_ES1_0) > >> > + SET_DMA_ERRATA(DMA_ERRATA_i88); > >> > + > >> > + /* > >> > + * Errata 3.2/3.3: sometimes 0 is returned if > CSAC/CDAC is > >> > >> This doesn't look like a unique errata identifier. Chapter 3 > >> is usually > >> the 'Cautions' section, and I don't listed in either the > 34xx (v5.9), > >> 36xx (v1.3) or 44xx (v1.3) errata docs under this number, and > >> don't see > >> that number in either of the 24xx errata docs either. > >> Please clarify. > > > > Even I tried to find this info from errata docs prior to migrating > > all errata's to generic errata handling. This code was > exising earlier, > > hence I retained it "as is", no documentation exists for > this errata. > > > > Hmm, OK. > > According to the code, it seems to affect every IP execpt > 1510, yet it's > not documented in any of the errata docs. > > I wonder what happens if it is removed? This errata work around is used in two API's: 1. omap_get_dma_src_pos 2. omap_get_dma_dst_pos which are used in sound and usb drivers. we can run sound and usb unit tests which are using above two API's and if there no issues, drop this errata work around? -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
