"G, Manjunath Kondaiah" <manjugk@xxxxxx> writes: >> "G, Manjunath Kondaiah" <manjugk@xxxxxx> writes: >> >> > Enable runtime pm and use pm_runtime_get and pm_runtime_put >> > for OMAP DMA driver. >> > >> > Signed-off-by: G, Manjunath Kondaiah <manjugk@xxxxxx> >> > Cc: Benoit Cousson <b-cousson@xxxxxx> >> > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> >> > Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx> >> > --- >> > arch/arm/plat-omap/dma.c | 13 +++++++++++++ >> > 1 files changed, 13 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c >> > index 41b14b0..feac7ee 100644 >> > --- a/arch/arm/plat-omap/dma.c >> > +++ b/arch/arm/plat-omap/dma.c >> > @@ -35,6 +35,7 @@ >> > #include <linux/io.h> >> > #include <linux/slab.h> >> > #include <linux/delay.h> >> > +#include <linux/pm_runtime.h> >> > >> > #include <asm/system.h> >> > #include <mach/hardware.h> >> > @@ -367,6 +368,8 @@ int omap_request_dma(int dev_id, const >> char *dev_name, >> > chan = dma_chan + free_ch; >> > chan->dev_id = dev_id; >> > >> > + pm_runtime_get(&pd->dev); >> >> The _get() call is asynchronous. So if the device was actually >> idled/disabled, immediately after this call it may still be >> idle/disabled. When using the asynchronous versions of the API, the >> device should not be touched until the driver's ->runtime_resume() >> callback is called. > > driver runtime_resume will call omap_device_enable. How do we make > we check from driver side, whether omap_device_enable execution is complete > or not. It is complete when the driver's runtime_resume hook is called. The OMAP runtime PM core calls omap_device_enable() before calling the driver's callback. See arch/arm/mach-omap2/pm_bus.c for details. Alternatively, just use _get_sync() which doesn't return until the device is ready. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
