RE: [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] 
> Sent: Wednesday, November 10, 2010 3:56 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap@xxxxxxxxxxxxxxx; 
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Cousson, Benoit; 
> Shilimkar, Santosh
> Subject: Re: [PATCH v3 10/13] OMAP: DMA: Convert DMA library 
> into DMA platform Driver
> 
> "G, Manjunath Kondaiah" <manjugk@xxxxxx> writes:
> 
> > Convert DMA library into DMA platform driver and make use
> > of platform data provided by HWMOD data base for OMAP2PLUS onwards.
> > For OMAP1 processors, the DMA driver in mach-omap uses resource
> > structures for getting platform data.
> >
> > Signed-off-by: G, Manjunath Kondaiah <manjugk@xxxxxx>
> > Cc: Benoit Cousson <b-cousson@xxxxxx>
> > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
> > Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> 
> [...]
> 
> > diff --git a/arch/arm/mach-omap2/include/mach/dma.h 
> b/arch/arm/mach-omap2/include/mach/dma.h
> > index d0a7d5b..d13c5c0 100644
> > --- a/arch/arm/mach-omap2/include/mach/dma.h
> > +++ b/arch/arm/mach-omap2/include/mach/dma.h
> > @@ -29,4 +29,7 @@
> >  #ifndef __ASM_ARCH_OMAP2_DMA_H
> >  #define __ASM_ARCH_OMAP2_DMA_H
> >  
> > +/* Should be part of hwmod data base ? */
> > +#define OMAP_DMA4_LOGICAL_DMA_CH_COUNT	32	/* 
> REVISIT: Is this 32 + 2? */
> > +
> 
> There are no users of this in this patch, all users are removed.

This macro is used in hwmod data base. Do you mean hard coding this
value in hwmod db and remove header?

-Manjunath
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux