On Wed, Nov 10, 2010 at 1:48 AM, Kevin Hilman
<khilman@xxxxxxxxxxxxxxxxxxx> wrote:
>> Â#if defined(CONFIG_OMAP_MBOX_FWK) || defined(CONFIG_OMAP_MBOX_FWK_MODULE)
>> +static struct omap_device_pm_latency mbox_latencies[] = {
>> + Â Â [0] = {
>> + Â Â Â Â Â Â .activate_func = omap_device_enable_clocks,
>> + Â Â Â Â Â Â .activate_lat = 50000, /* FIXME random value */
>> + Â Â Â Â Â Â .deactivate_func = omap_device_enable_clocks,
>> + Â Â Â Â Â Â .deactivate_lat = 50000, /* FIXME random value */
>> + Â Â },
>> +};
>
> hmm, I'm hoping you're not expecting this to merge when using random values.
No, I was hoping you would comment in the RFC I sent clearly
mentioning this was an experiment 6 months ago:
http://thread.gmane.org/gmane.linux.ports.arm.omap/36745
AFAICR this was one of the first patches for hwmod, so there was not
much reference. I did see more proper ways to set those latencies
after sending that patch (automatic calculation IIRC), but I didn't
manage to work on that code again. There are more important things to
do, like getting the only user of the mailbox to actually work.
>> --- a/arch/arm/mach-omap2/mailbox.c
>> +++ b/arch/arm/mach-omap2/mailbox.c
>> @@ -53,6 +53,7 @@
>> Â#define OMAP4_MBOX_NR_REGS Â Â Â Â Â (OMAP4_MBOX_REG_SIZE / sizeof(u32))
>>
>> Âstatic void __iomem *mbox_base;
>> +static struct platform_device *mbox_pdev;
>> + Â Â mbox_pdev = pdev;
>
> please don't use a global for this. ÂWhat if a future SoC has more than
> one mailbox?
>
> How about adding a field to struct omap_mbox?
If you see above, there can be only one (mbox_base is already global).
So support for multiple mailboxes would be the subject of a separate
patch.
Cheers.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
