Hi,
On Fri, 2010-11-05 at 20:43 +0100, ext Bryan Wu wrote:
> Introduce struct panel config data in panel.h, which will be used to match
> the right panel configurations in generic DPI panel driver and other future
> dsi panel drivers.
>
> Still keep sharp_ls_panel, since the sharp_ls_panel driver contains blacklight
> control driver code which will be moved out later. Then we can use generic DPI
> driver for sharp_ls_panel.
As mentioned in the other mail, don't touch panel-taal or
nokia-dsi-panel.h. They are not related to this change.
The panel.h file should be spesific for the generic panel driver, so
name the .c and .h files similarly. (yes, panel-taal.c and
nokia-dsi-panel.h are not good examples for this, but I have a patch
fixing it, I just haven't had time to push it forward =).
And remember that the kernel should compile and work after each
individual patch in the patch set. In this patch you set the boards to
use dvi_panel driver, but there is no dvi_panel driver yet.
Also some comments inline.
> Signed-off-by: Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
> ---
> arch/arm/mach-omap2/board-3430sdp.c | 10 +++-
> arch/arm/mach-omap2/board-am3517evm.c | 19 +++++--
> arch/arm/mach-omap2/board-cm-t35.c | 19 +++++--
> arch/arm/mach-omap2/board-devkit8000.c | 22 +++++---
> arch/arm/mach-omap2/board-igep0020.c | 10 +++-
> arch/arm/mach-omap2/board-omap3beagle.c | 10 +++-
> arch/arm/mach-omap2/board-omap3evm.c | 10 +++-
> arch/arm/mach-omap2/board-omap3stalker.c | 19 +++++--
> arch/arm/plat-omap/include/plat/nokia-dsi-panel.h | 31 -----------
> arch/arm/plat-omap/include/plat/panel.h | 57 +++++++++++++++++++++
> drivers/video/omap2/displays/panel-taal.c | 26 ++++------
> 11 files changed, 148 insertions(+), 85 deletions(-)
> delete mode 100644 arch/arm/plat-omap/include/plat/nokia-dsi-panel.h
> create mode 100644 arch/arm/plat-omap/include/plat/panel.h
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 4e3742c..859b4e5 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -38,6 +38,7 @@
> #include <plat/dma.h>
> #include <plat/gpmc.h>
> #include <plat/display.h>
> +#include <plat/panel.h>
>
> #include <plat/gpmc-smc91x.h>
>
> @@ -270,11 +271,14 @@ static struct omap_dss_device sdp3430_lcd_device = {
> .platform_disable = sdp3430_panel_disable_lcd,
> };
>
> +static struct panel_data dvi_panel = {
> + .name = "generic",
> +};
> +
> static struct omap_dss_device sdp3430_dvi_device = {
> .name = "dvi",
> - .driver_name = "generic_panel",
> - .type = OMAP_DISPLAY_TYPE_DPI,
> - .phy.dpi.data_lines = 24,
Why do you remove type and datalines configuration? You do this for the
other panels also.
Tomi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
