On Sat, Nov 6, 2010 at 3:47 PM, Cousson, Benoit <b-cousson@xxxxxx> wrote:
> On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote:
>>
>> Add mmu hwmod data for ducati and tesla.
>
> s/ducati/ipu/
> s/tesla/dsp/
>
> Please do not use internal codename.
Tried to avoid confusion with what was originally in the driver, agree
with the change.
> Here again, you completely changed the omap4 existing data for (almost)
> nothing.
>
> I agree, the original code was not considering the mmu as a hwmod but only
> the core of the subsystem: mmu + cache.
>
> But as far as I can see, you just added a new mmu class, a dev_attr, and the
> hwmod remain almost the same.
> Otherwise, you replaced the proper names by the bad one, and you removed
> important data (hw reset for ex).
>
> Please start from the original code and fix what is missing or wrong but do
> not re-write everything.
I wrote this one from scratch, I didn't see that there were pieces to
handle some stuff since the code is buried in a private tree.
I cared to dug up the mailbox one, but completely missed this one.
>> +/* mmu */
>> +
>> +static struct omap_hwmod_class omap44xx_mmu_hwmod_class = {
>> + .name = "mmu",
>> +};
>
> That change is OK. The remaining part seems to be completely broken.
>
>> +
>> +/* ducati mmu */
>> +
>> +static struct omap_hwmod omap44xx_ducati_mmu_hwmod;
>> +
>> +static struct omap_hwmod_addr_space omap44xx_ducati_mmu_addrs[] = {
>> + {
>> + .pa_start = OMAP4_MMU1_BASE,
>> + .pa_end = OMAP4_MMU1_BASE + SZ_4K - 1,
>> + .flags = ADDR_TYPE_RT,
>> + },
>> +};
>> +
>> +/* l3_main_1 -> ducati mmu */
>> +static struct omap_hwmod_ocp_if omap44xx_l3_main_1__ducati_mmu = {
>> + .master =&omap44xx_l3_main_1_hwmod,
>> + .slave =&omap44xx_ducati_mmu_hwmod,
>> + .addr = omap44xx_ducati_mmu_addrs,
>> + .clk = "dpll_mpu_m2_ck",
>
> Are you sure of that?
No, this was supposed to be the hwmod main_clk... the ocp_if clk
should be l3_div.
I will add these changes and the ones you mention as "mmu + cache",
and see how it goes from there.
Regards,
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
