Hi Rene,
On Fri, 2010-11-05 at 16:12 -0600, Sapiens, Rene wrote:
> Hi Ionut,
>
> On Fri, Nov 5, 2010 at 9:13 AM, Ionut Nicu <ionut.nicu@xxxxxxxxx> wrote:
> > Convert the core module of the tidspbridge driver
> > to use struct list_head instead of struct lst_list.
> >
> > Signed-off-by: Ionut Nicu <ionut.nicu@xxxxxxxxxx>
>
> <snip>
>
> > diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c
> > index 194bada..9851f32 100644
> > --- a/drivers/staging/tidspbridge/core/io_sm.c
> > +++ b/drivers/staging/tidspbridge/core/io_sm.c
>
> <snip>
>
> > @@ -1106,47 +1103,38 @@ static void input_msg(struct io_mgr *pio_mgr, struct msg_mgr *hmsg_mgr)
> > * queued.
> > */
> > (*hmsg_mgr->on_exit) ((void *)
> > - msg_queue_obj->arg,
> > - msg.msg.dw_arg1);
> > + msg_queue_obj->arg,
> > + msg.msg.dw_arg1);
> > + break;
> > + }
> > + /*
> > + * Not an exit acknowledgement, queue
> > + * the message.
> > + */
> > + if (!list_empty(&msg_queue_obj->msg_free_list)) {
>
> You are going beyond the 80 chars.
>
I thought about it too when using scripts/checkpatch.pl on this patch.
The thing is that it's 81 chars and breaking it into two lines makes it
look uglier. Also, this gets fixed in patch 10/12 (core code cleanup).
Regards,
Ionut.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
