On Thu, Nov 4, 2010 at 19:13, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Nishanth Menon <nm@xxxxxx> [101019 17:53]:
>> @@ -86,7 +87,10 @@ int __init omap_init_opp_table(void)
>> omap_table_init = 1;
>>
>> /* Select the OPP table we'd like to enable based on cpu we are on */
>> - if (cpu_is_omap34xx()) {
>> + if (cpu_is_omap44xx()) {
>> + opp_def = omap44xx_opp_def_list;
>> + opp_def_size = ARRAY_SIZE(omap44xx_opp_def_list);
>> + } else if (cpu_is_omap34xx()) {
>> opp_def = cpu_is_omap3630() ? omap36xx_opp_def_list :
>> omap34xx_opp_def_list;
>> opp_def_size = cpu_is_omap3630() ?
>
> And based on the comments in patch 1/3, when you add support for
> new processor, you just add a new init function instead of adding
> "if cpu_is_omapxxxx else if" chunks.
yeah it does sound better and i like the approach as well. thanks for
the same. will post a v3 asap.
Regards,
NM
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
