2010/11/2 Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>: > On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote: >> Add missing dependencies, and remove redundant ones, and select sensible >> defaults. >> >> This is more user-friendly, and logical. >> >> Â- TWL4030_CORE people should be able to compile without ARM >> Â- REGULATOR_TWL4030 if TWL4030_CORE and REGULATOR, it's pretty clear we >> Â Âwant this >> Â- USB_GADGET_SELECTED is already inside USB_GADGET >> Â- USB_GADGET_OMAP only works on ARCH_OMAP1, and USB_OTG_UTILS is >> Â Âalready selected by NOP_USB_XCEIV >> Â- USB_GADGET_R8A66597 is meant for ARCH_SHMOBILE >> Â- USB_MUSB_HDRC needs either NOP_USB_XCEIV, or TWL4030_USB >> Â- USB_MUSB_AM35X, NOP_USB_XCEIV is already selected because MACH_OMAP3EVM >> >> Finally, move: >> config USB_MUSB_HDRC >> Â Â Â select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN) >> Â Â Â select TWL4030_USB if MACH_OMAP_3430SDP >> >> To: >> config TWL4030_USB >> Â Â Â default y if ARCH_OMAP3 >> >> config NOP_USB_XCEIV >> Â Â Â default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN >> >> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> > All changes look fine to me, but I think you will need to split up this > patch for the different subsystem maintainers. Ok, will do. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html