On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote: > >> Âconfig REGULATOR_TWL4030 >> Â Â Â bool "TI TWL4030/TWL5030/TWL6030/TPS695x0 PMIC" >> Â Â Â depends on TWL4030_CORE >> + Â Â default y >> Â Â Â help >> Â Â Â Â This driver supports the voltage regulators provided by >> Â Â Â Â this family of companion chips. > > This default is not suitable for non-OMAP platforms, it should be > conditional on OMAP or something if we're going to do this (though > generally we handle this with defconfigs rather than in Kconfig). This would only be enabled when TWL4030_CORE is enabled, so non-OMAP platforms would not get affected. I guess you have seen the complaint from Linus regarding ARM relying too much on defconfigs. This helps in order to simplify defconfigs, and eventually getting rid of them completely. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html