> -----Original Message----- > From: Jarkko Nikula [mailto:jhnikula@xxxxxxxxx] > Sent: Tuesday, November 02, 2010 4:03 PM > To: Datta, Shubhrajyoti > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2] McBSP: Fix the free variable update at remove. > > On Tue, 2 Nov 2010 15:54:48 +0530 > shubhrajyoti@xxxxxx wrote: > > > From: Shubhrajyoti D <shubhrajyoti@xxxxxx> > > > > At remove the free variable is wrongly updated.Attempting to solve the > same. > > > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> > > --- > > -[v2] Instead of using 0/1 use a macro > > > > arch/arm/plat-omap/include/plat/mcbsp.h | 3 +++ > > arch/arm/plat-omap/mcbsp.c | 10 +++++----- > > 2 files changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/plat-omap/include/plat/mcbsp.h b/arch/arm/plat- > omap/include/plat/mcbsp.h > > index b87d83c..8988733 100644 > > --- a/arch/arm/plat-omap/include/plat/mcbsp.h > > +++ b/arch/arm/plat-omap/include/plat/mcbsp.h > > @@ -37,6 +37,9 @@ static struct platform_device omap_mcbsp##port_nr = { > \ > > .id = OMAP_MCBSP##port_nr, \ > > } > > > > +#define TRUE 1 > > +#define FALSE 0 > > + > Use 'true' & 'false' in the code instead and then there is no need to > redefine these. They are defined in include/linux/stddef.h which is > probably included already by some another file. > Yes missed it. Will fix that. > > -- > Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
