On Wed, Oct 27, 2010 at 12:00 PM, Grazvydas Ignotas <notasas@xxxxxxxxx> wrote: > On Wed, Oct 27, 2010 at 10:28 AM, Felipe Contreras > <felipe.contreras@xxxxxxxxx> wrote: >> On Wed, Oct 27, 2010 at 8:06 AM, Varadarajan, Charulatha <charu@xxxxxx> wrote: >>> >>> Use cpu_is_* check only. No need to have #if CONFIG_ARCH_* checks. >> >> Some people conditionally compile only for one architecture, like in >> consumer devices. There's no point in wasting space for that. > > And cpu_is_* calls become constants in such cases, allowing compiler > to optimize away unneeded 'if' blocks, not to mention cpu_is_* allows > multi-omap support. cpu_is_* is the way to go. The problem is not the cpu_is_* calls, the problem is what is inside them (e.g. omap3_mboxes). If CONFIG_ARCH_OMAP3 is not defined, then compilation would be broken, unless you always include all the arrays. Multi-omap support is already there, because it means CONFIG_ARCH_OMAP3, CONFIG_ARCH_OMAP2, etc. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
