On Tue, Oct 26, 2010 at 1:33 AM, Thomas Renninger <trenn@xxxxxxx> wrote: > Changes in V2: > - Introduce PWR_EVENT_EXIT instead of 0 to mark non-power state > - Use u32 instead of u64 for cpuid, state which is by far enough > > New power trace events: > power:processor_idle > power:processor_frequency > power:machine_suspend > > > C-state/idle accounting events: > power:power_start > power:power_end > are replaced with: > power:processor_idle > > and > power:power_frequency > is replaced with: > power:processor_frequency > > power:machine_suspend > is newly introduced, a first implementation > comes from the ARM side, but it's easy to add these events > in X86 as well if needed. This will come as a separate patch, which fits all platforms. Cf. http://marc.info/?l=linux-omap&m=128620575300682&w=2. ... > @@ -481,10 +484,12 @@ static void mwait_idle(void) > static void poll_idle(void) > { > trace_power_start(POWER_CSTATE, 0, smp_processor_id()); > + trace_processor_idle(1, smp_processor_id()); Should that be: + trace_processor_idle(0, smp_processor_id()); instead? Since state '0' is for the CPU active in polling mode and PWR_EVENT_EXIT means 'exit from any idle state'. > local_irq_enable(); > while (!need_resched()) > cpu_relax(); > - trace_power_end(0); > + trace_power_end(smp_processor_id()); > + trace_processor_idle(PWR_EVENT_EXIT, smp_processor_id()); > } > > /* ... > diff --git a/include/trace/events/power.h b/include/trace/events/power.h ... Regards, Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
