>>-----Original Message-----
>>From: Cousson, Benoit
>>Sent: Monday, October 25, 2010 3:00 PM
>>To: Gopinath, Thara
>>Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxxxxxxxxxxxxxxx; paul@xxxxxxxxx;
>>Sripathy, Vishwanath; Sawant, Anand
>>Subject: Re: [PATCH v3 01/11] OMAP: PM: Export the main pm debugfs directory
>>
>>On 9/22/2010 4:45 PM, Gopinath, Thara wrote:
>>> This patch makes generic pm_debug directory global
>>> so that other drivers can include it and use it to create
>>> sub-entries.
>>
>>That should not be needed, if we expose voltage debugfs entry in the top
>>level directly.
Agreed. I am ok with exposing the voltage debugfs entry at the top level.
Regards
Thara
>>
>>Benoit
>>
>>>
>>> Signed-off-by: Thara Gopinath<thara@xxxxxx>
>>> ---
>>> arch/arm/mach-omap2/pm-debug.c | 3 +++
>>> arch/arm/mach-omap2/pm.h | 1 +
>>> 2 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-
>>debug.c
>>> index af00c17..390f1c6 100644
>>> --- a/arch/arm/mach-omap2/pm-debug.c
>>> +++ b/arch/arm/mach-omap2/pm-debug.c
>>> @@ -42,6 +42,7 @@ u32 enable_off_mode;
>>> u32 sleep_while_idle;
>>> u32 wakeup_timer_seconds;
>>> u32 wakeup_timer_milliseconds;
>>> +struct dentry *pm_dbg_main_dir;
>>>
>>> #define DUMP_PRM_MOD_REG(mod, reg) \
>>> regs[reg_count].name = #mod "." #reg; \
>>> @@ -641,6 +642,8 @@ static int __init pm_dbg_init(void)
>>> (void) debugfs_create_file("wakeup_timer_milliseconds",
>>> S_IRUGO | S_IWUGO, d,&wakeup_timer_milliseconds,
>>> &pm_dbg_option_fops);
>>> +
>>> + pm_dbg_main_dir = d;
>>> pm_dbg_init_done = 1;
>>>
>>> return 0;
>>> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
>>> index f3ba1e6..c06cedd 100644
>>> --- a/arch/arm/mach-omap2/pm.h
>>> +++ b/arch/arm/mach-omap2/pm.h
>>> @@ -55,6 +55,7 @@ extern int omap2_pm_debug;
>>> #define omap2_pm_dump(mode, resume, us) do {} while (0);
>>> #define omap2_pm_wakeup_on_timer(seconds, milliseconds) do {} while (0);
>>> #define omap2_pm_debug 0
>>> +#define pm_dbg_main_dir 0
>>> #endif
>>>
>>> #if defined(CONFIG_CPU_IDLE)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
