Hi Rene, On Sat, 2010-10-23 at 15:28 -0500, Sapiens, Rene wrote: > Hi Ionut, > On Friday, October 22, 2010 9:09 AM Ionut Nicu wrote: > > Most likely I will have to break patch 4/4 from this series (which I > > also believe is way too big) into multiple patches and re-submit. > > > > I'm expecting some advices from the maintainers/list on how to split > > patch 4 (lst_list removal). > > I have a version of this patch but yours did it first :). You can break > it by functionality so that you don't break nor affect bridge's behavior > i.e. > > Patch 1 can include the removing of the wrapper from: > drivers/staging/tidspbridge/core/_msg_sm.h > drivers/staging/tidspbridge/core/chnl_sm.c > drivers/staging/tidspbridge/core/io_sm.c > drivers/staging/tidspbridge/core/msg_sm.c > drivers/staging/tidspbridge/include/dspbridge/_chnl_sm.h > drivers/staging/tidspbridge/include/dspbridge/cmmdefs.h > The above files share some of the lists. > > Patch 2: > drivers/staging/tidspbridge/pmgr/cmm.c > > Patch 3: > drivers/staging/tidspbridge/pmgr/dev.c > drivers/staging/tidspbridge/rmgr/drv.c > drivers/staging/tidspbridge/rmgr/node.c > drivers/staging/tidspbridge/rmgr/proc.c > > Patch 4: > drivers/staging/tidspbridge/rmgr/rmm.c > > Patch 5: > Removing of the not needed files. > Thanks for your suggestions. I will try to do this split-up in version 2 of this series. Best regards, Ionut. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html