>>-----Original Message----- >>From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >>owner@xxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman >>Sent: Friday, October 15, 2010 12:51 AM >>To: Gopinath, Thara >>Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; Cousson, Benoit; Sripathy, >>Vishwanath; Sawant, Anand >>Subject: Re: [PATCH v3 08/11] OMAP3: PM: Adding debug support to Voltage and >>Smartreflex drivers >> >>On Wed, 2010-09-22 at 20:15 +0530, Thara Gopinath wrote: >>> --- a/arch/arm/mach-omap2/smartreflex.c >>> +++ b/arch/arm/mach-omap2/smartreflex.c >>> @@ -558,8 +558,13 @@ int sr_enable(struct voltagedomain *voltdm, >>> unsigned long volt) >>> return -ENODATA; >>> } >>> >>> - /* errminlimit is opp dependent and hence linked to voltage */ >>> - sr->err_minlimit = volt_data->sr_errminlimit; >>> + /* >>> + * errminlimit is opp dependent and hence linked to voltage >>> + * if the debug option is enabled, the user might have over >>> ridden >>> + * this parameter so do not get it from voltage table >>> + */ >> >>this comment needs better punctuation to be clearer Will do >> >>> + if (!enable_sr_vp_debug) >>> + sr->err_minlimit = volt_data->sr_errminlimit; >> >>Rather than checking if debug is enabled, you should create a flag >>specific to whether this value was overwritten by the user, and use that >>flag instead. mmm.. See my comment regarding flag and enable_sr_vp_debug in the other patch Regards Thara >> >>Kevin >> >> >>-- >>To unsubscribe from this list: send the line "unsubscribe linux-omap" in >>the body of a message to majordomo@xxxxxxxxxxxxxxx >>More majordomo info at http://vger.kernel.org/majordomo-info.html ÿô.nlj·Ÿ®‰†+%ŠË±é¥Šwÿº{.nlj·¥Š{±þ‰š§ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf
