On Thu, Oct 21, 2010 at 12:57:41PM -0500, Kevin Hilman wrote:
Felipe Balbi <balbi@xxxxxx> writes:
Add 32k timer hwmod to the database.
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
Not sure how this is working correctly on OMAP2 and OMAP3. All the
hwmods are mising the oh->prcm.omap2.module_offs field.
Without this, _wait_target_ready *should* fail, and the hwmod should not
actually be enabled.
Since this was tested to work, I guess what's happening, is because
module_offs == 0 (OCP_MOD), it's reading from the IDLEST register offset
in OCP_MOD, which is an undefined register. On 34xx, we get lucky that
that bit is zero so omap2_cm_wait_module_ready succeeds. On 24xx, the
polarity of the idlest bits is inversed, so this would likely fail on
OMAP2.
Either way, the right fix for this is to ensure that OMAP2/3 hwmods have
.module_offs populated correctly.
I'll look again but when I was reading omap3 TRM I couldn't find IDLEST
for this module, maybe I missed something.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
