From: "ext Guzman Lugo, Fernando" <fernando.lugo@xxxxxx> Subject: RE: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap Date: Thu, 14 Oct 2010 10:18:30 +0200 > >> ________________________________________ >> From: Hiroshi DOYU [Hiroshi.DOYU@xxxxxxxxx] >> Sent: Thursday, October 14, 2010 1:45 AM >> To: Guzman Lugo, Fernando >> Cc: felipe.contreras@xxxxxxxxx; tony@xxxxxxxxxxx; >> linux-kernel@xxxxxxxxxxxxxxx; andy.shevchenko@xxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap >> >> Hi Fernando, >> >> From: ext Fernando Guzman Lugo <x0095840@xxxxxx> >> Subject: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap >> Date: Thu, 14 Oct 2010 04:27:36 +0200 >> >> > Omap platform is omap_iounmap function. >> > >> > Signed-off-by: Fernando Guzman Lugo <x0095840@xxxxxx> >> > --- >> > arch/arm/plat-omap/iovmm.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c >> > index 93a34d9..5489ca9 100644 >> > --- a/arch/arm/plat-omap/iovmm.c >> > +++ b/arch/arm/plat-omap/iovmm.c >> > @@ -821,7 +821,7 @@ void iommu_kunmap(struct iommu *obj, u32 da) >> > struct sg_table *sgt; >> > typedef void (*func_t)(const void *); >> > >> > - sgt = unmap_vm_area(obj, da, (func_t)__iounmap, >> >> + sgt = unmap_vm_area(obj, da, (func_t)iounmap, >> >> Woundn't the above be enough? >> >> Eventually this "iounmap()" calls "__arch_iounmap()" -> >> "omap_iounmap()". I don't see any special reason to call >> "omap_iounmap()" here for now. > > iounmap and __arch_iounmap are macros they cannot not > be used there. If so, it gives a "undeclared" compile error. Ok. I'll add this explanation as a note on this commit. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
