Re: [PATCH 1/3] OMAP: control: add functions for DSP boot address/mode control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A few other items:

On Mon, 11 Oct 2010, Paul Walmsley wrote:

> A few other things should be done also.
> 
> 1. Most of the code in drivers/staging/tidspbridge/code/tiomap3430.c in 
> the bridge_brd_monitor(), bridge_brd_start(), and bridge_brd_stop() should 
> be moved into a file in arch/arm/mach-omap2.  The DSPBridge driver should 
> call those functions (to reset the DSP, start it, etc.) through 
> platform_data function pointers.  Once that happens, patch 3 of the 
> control module-related series would not be needed, since that code would 
> be in arch/arm/mach-omap2 anyway.

This also includes some of the code from core/tiomap3430_pwr.c, such as 
handle_hibernation_from_dsp() and dsp_clk_wakeup_event_ctrl().  
Basically, all of the other code that directly reads or writes registers 
outside the IVA2 directly needs to be moved into arch/arm/mach-omap2.

> 2. The direct CM/PRM/RM register access should be removed from that 
> arch/arm/mach-omap2 code.  That should be handled directly by the 
> clock/hwmod/whatever code.
> 
> 3. DSPBridge should be converted to use PM runtime, and the 
> arch/arm/mach-omap2 portion should use omap_device, omap_hwmod, etc.

4. If the DSP uses a peripheral, such as a GPTIMER or a McBSP, DSPBridge 
needs to reserve that device with the rest of Linux so some other Linux 
code isn't using it or doesn't try to use it, causing conflicts with 
DSPBridge.  I guess the list that we need to worry about is in _tiomap.h 
as l4_peripheral_table[].


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux