On Mon, Oct 11, 2010 at 1:40 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Sunday 10 October 2010, Felipe Contreras wrote: >> The mempool area is not handled by the kernel any more. > > But tidspbridge still uses ioremap to set up the mapping for RAM, > even though it now is outside of the kernel linar mapping. Which is what ioremap() complained about, and how Russell King suggested to solve the issue. > You should really only use ioremap on MMIO registers, nothing > else. These registers are marked as __iomem pointers and can only > be passed into functions that talk to the hardware like iowrite32 > or writel, but not used like memory. >From what I can see parts of this memory are also used for readl/writel. > Please have a look at "sparse", which will warn about address space > violations among other things. The tidspbridge driver is full of them, > and you should fix the code that sparse warns about, which will > also show you all the places where ioremap is used incorrectly. In one of my branches I moved ioremap() to arch/arm/mach-omap2/dsp.c and if I use sparse there, it gives no warning. I would prefer to map the memory some other way and make it non-cacheable, but I don't know any other way. Then, if readl/writel are still needed, only ioremap() that area. And finally, and hopefully, do cache flushes instead of requiring consistent memory. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
