Tony, > -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Friday, October 08, 2010 11:06 PM > To: Menon, Nishanth > Cc: Poddar, Sourav; linux-omap@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Shilimkar, Santosh; G, > Manjunath Kondaiah; Varadarajan, Charulatha > Subject: Re: [PATCH v4] ARM: Fix sparse warnings due to > variables conflicts. > > * Nishanth Menon <nm@xxxxxx> [101008 04:24]: > > Poddar, Sourav had written, on 10/08/2010 12:53 AM, the following: > > >Fix the sparse warnings generated due to conflicts in > variables used in readl/writel. > > > > > > > > >drivers/net/smc91x.c:312:8: warning: symbol '__v' shadows > an earlier > > >one > > >drivers/net/smc91x.c:312:8: originally declared here > > > > > >With this change, about 200 sparse warnings are fixed. > > The commit message could be a little more detailed. > > see http://marc.info/?l=linux-omap&m=128648102511076&w=2 > > > > also should $subject say ARM: io: fix namespace conflict to better > > reflect the fix? sparse warnings are just an indication IMHO > > BTW, also dropping the "OMAP: Convert write/read functions to > raw read/write". > > That patch does not compute, and also ends up leaving files > with __raw_readw followed by writew.. > Why to revert patch "OMAP: Convert write/read functions to raw read/write" since we need to replace other __raw_read/__raw_writel functions if above patch gets accepted. -Manjunath-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
