Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> writes: > Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> writes: > >> This patch reverts commit 914bab936fe0388a529079679e2f137aa4ff548d, which >> breaks the OFF mode on the OMAP3 platforms. >> The details are here below. >> >> The intent behind the original patch was to fix some compiler >> warnings, which I do not have on my side. Is the problem dependent on >> the setup and config used? > >> From ec85bc90978cf0f257e73eaad593ffb774595863 Mon Sep 17 00:00:00 2001 >> From: Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> >> Date: Fri, 8 Oct 2010 18:36:48 +0200 >> Subject: [PATCH] Revert "OMAP: mach-omap2: Fix incorrect assignment warnings" >> >> This reverts commit 914bab936fe0388a529079679e2f137aa4ff548d, which >> breaks the OFF mode on the OMAP3 platforms. >> >> The use of a void* pointer for scratchpad_address confuses the >> compiler which generates wrong offset for the access to the L4 >> address space. In that case an alignement fault is generated >> during the wake-up from OFF mode. >> >> The code that causes problem is: >> __raw_readl(scratchpad_address + OMAP343X_TABLE_ADDRESS_OFFSET); > > Thanks Jean for tracking down why off-mode was broken on the master > branch. > > I completely agree this patch should be reverted. However, the > description here could be a litle more descriptive. I changed my mind... Since only one part of the original patch introduced a bug, I decided to just fix that bug and keep the fixes for the sparse warnings. I just posted a patch[1] for the fix. Please test. Thanks, Kevin [1] https://patchwork.kernel.org/patch/242661/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
