On Thu, Oct 07, 2010 at 07:17:08AM -0500, Menon, Nishanth wrote: > > > -----Original Message----- > > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > > owner@xxxxxxxxxxxxxxx] On Behalf Of G, Manjunath Kondaiah > > Sent: Tuesday, September 21, 2010 5:01 AM > > To: linux-omap@xxxxxxxxxxxxxxx > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx > > Subject: [PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw > > read/write > > > > Following sparse warnings exists due to use of writel/w and readl/w > > functions. > > > > This patch fixes the sparse warnings by converting readl/w functions usage > > into > > __raw_readl/__raw_readw functions. > > Apologies on bringing up an old topic here -> Is'nt it better to fix > readl/w or writel/w than replacing it with __raw_readl/w etc? No. If you're getting sparse warnings its because _you_ are using readl/writel wrongly. They take a void __iomem pointer, not a u32, unsigned long, int, or even a void pointer. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
