> -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Thursday, October 07, 2010 6:30 PM > To: Guruswamy, Senthilvadivu > Cc: Hiremath, Vaibhav; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v5 3/3] OMAP: DSS2: OMAPFB: Allow usage of def_vrfb > only for omap2,3 > > On Thu, 2010-10-07 at 13:15 +0200, ext Guruswamy Senthilvadivu wrote: > > From: Senthilvadivu Guruswamy <svadivu@xxxxxx> > > > > For Non-VRFB devices/platforms (omap2, omap3 family) force it to the > > DMA based rotation. > > This sounds a bit confusing, as if omap2 and omap3 are Non-VRFB devices. > [Hiremath, Vaibhav] My bad. Mistakenly typed omap2/3 here. Thanks, Vaibhav > And I'm not sure it's exactly correct to say "forcing to DMA rotation". > We're just disallowing the use of VRFB, not forcing to use DMA rotation. > Of course DMA rotation is currently the only other option, but still. > > I'd put it: > > VRFB is supported on OMAP2 and OMAP3 platforms. If VRFB rotation is not > supported by the hardware and the user requests VRFB rotation, print a > warning and ignore the request from the user. > > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx> > > --- > > drivers/video/omap2/omapfb/omapfb-main.c | 10 ++++++++++ > > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/video/omap2/omapfb/omapfb-main.c > b/drivers/video/omap2/omapfb/omapfb-main.c > > index bddfca6..fcd9038 100644 > > --- a/drivers/video/omap2/omapfb/omapfb-main.c > > +++ b/drivers/video/omap2/omapfb/omapfb-main.c > > @@ -2198,6 +2198,16 @@ static int omapfb_probe(struct platform_device > *pdev) > > goto err0; > > } > > > > + /* TODO : Replace cpu check with omap_has_vrfb once HAS_FEATURE > > + * available for OMAP2 and OMAP3 > > + */ > > + if (def_vrfb && (!cpu_is_omap24xx()) && (!cpu_is_omap34xx())) { > > The parenthesis are extra around !cpu_is_xxxx calls. > > > + def_vrfb = 0; > > + dev_warn(&pdev->dev, "VRFB is not in this device," > > + "using DMA for rotation\n"); > > How about: "VRFB is not supported by the hardware, ignoring vrfb=y > module parameter". > > Otherwise I think the patch set is ok. If you're fine with these > changes, I can make them while applying these to my tree. Or send a new > patch set, both are fine for me. > > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
