Hi, On Wed, 2010-09-15 at 16:09 +0200, ext archit@xxxxxx wrote: > From: Archit Taneja <archit@xxxxxx> > > Add dss_features.c and dss_features.h for the dss_features framework > > Signed-off-by: Archit Taneja <archit@xxxxxx> > --- <snip> > +struct omap_dss_features { > + const struct dss_reg_field *reg_fields; > + const int num_reg_fields; > + > + const u32 has_feature; I only now noticed that you had changed the feature list to a bit array. It was an array of ints previously. Are you sure 32 features is enough? It sounds a bit small to me. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html