> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, October 05, 2010 10:34 PM > To: Nayak, Rajendra > Cc: Paul Walmsley; Cousson, Benoit; Tony Lindgren; linux-omap@xxxxxxxxxxxxxxx; Varadarajan, Charulatha; Raja, > Govindraj > Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c > > "Nayak, Rajendra" <rnayak@xxxxxx> writes: > > > <snip>.. > > > >> > > >> > Below is an untested patch to provide some mechanism to deal with this -- > >> > I'd appreciate everyone's comments on this, particularly the comments in > >> > the patch code on how to deal with this problem. > >> > >> Hi Paul, > >> > >> I'll test this patch to see if it solves the issue seen with i2c on n800. > > > > Hi Paul, Benoit, Kevin, > > > > So looks like the issue with i2c on n800 isn't really because of additional > > delay needed after a clock enable, but related to the omap_readl/writel's > > done on the 16bit i2c registers as I was suspecting earlier. > > > > The below patch fixes the n800 issue for me. My mailer might mess up the alignment > > hence attaching it too. > > > > From af9733f2e63a16b446635d52015e05d631f0788f Mon Sep 17 00:00:00 2001 > > From: Rajendra Nayak <rnayak@xxxxxx> > > Date: Tue, 5 Oct 2010 16:36:30 +0530 > > Subject: [PATCH] OMAP: hwmod: Handle modules with 16bit registers > > > > Some modules which have 16bit registers can cause imprecise > > aborts if a __raw_readl/writel is used to read/write 32 bits. > > > > Add an additional flag to identify modules which have such > > hard requirement, and handle it in the hwmod framework. > > > > Signed-off-by: Rajendra Nayak <rnayak@xxxxxx> > > Can you also send a corresponding patch to the i2c hwmod data. Hi Kevin, Ok, I'll repost the original patch which adds the omap2 hwmod data with these flags added for omap2420. Does that sound fine? Regards, Rajendra > > I'll rebase the rest of the series against current l-o master, and maybe > we can still get this in for .37. > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
