> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Peter Ujfalusi > Sent: Tuesday, October 05, 2010 12:16 PM > To: Tony Lindgren > Cc: linux-omap@xxxxxxxxxxxxxxx; Jarkko Nikula; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Russell King > Subject: [PATCH v5 1/3] omap: dma: Fix buffering disable bit > setting for omap24xx > > From: Jarkko Nikula <jhnikula@xxxxxxxxx> ... > > /* > - * Errata: On ES2.0 BUFFERING disable must be set. > - * This will always fail on ES1.0 > + * Errata: Inter Frame DMA buffering issue (All OMAP2420 and > + * OMAP2430ES1.0): DMA will wrongly buffer elements if > packing and > + * bursting is enabled. This might result in data gets > stalled in > + * FIFO at the end of the block. > + * Workaround: DMA channels must have > BUFFERING_DISABLED bit set to > + * guarantee no data will stay in the DMA FIFO in case > inter frame > + * buffering occurs. > */ > - if (cpu_is_omap24xx()) > - l |= OMAP_DMA_CCR_EN; > + if (cpu_is_omap2420() || > + (cpu_is_omap2430() && (omap_type() == OMAP2430_REV_ES1_0))) > + l |= OMAP_DMA_CCR_BUFFERING_DISABLE; Acked-by: G, Manjunath Kondaiah <manjugk@xxxxxx> -Manjunath-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
