> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Peter Ujfalusi > Sent: Monday, October 04, 2010 1:48 PM > To: Tony Lindgren > Cc: linux-omap@xxxxxxxxxxxxxxx; Jarkko Nikula; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO > draining does not finish > ... > + /* OMAP3 Errata i541: sDMA FIFO draining does not finish */ This logic is required for multiple erratas. Can we have seperate function for handling this logic. More details at: https://patchwork.kernel.org/patch/126271/ ... > --- a/arch/arm/plat-omap/include/plat/dma.h > +++ b/arch/arm/plat-omap/include/plat/dma.h > @@ -335,6 +335,9 @@ > #define OMAP2_DMA_MISALIGNED_ERR_IRQ (1 << 11) > > #define OMAP_DMA_CCR_EN (1 << 7) > +#define OMAP_DMA_CCR_RD_ACTIVE (1 << 9) > +#define OMAP_DMA_CCR_WR_ACTIVE (1 << 10) > +#define OMAP_DMA_CCR_SEL_SRC_DST_SYNC (1 << 24) > #define OMAP_DMA_CCR_BUFFERING_DISABLE (1 << 25) As I mentioned in other mail, if you are introducing this feature, it is better to convert existing erratas also to use this feature. -Manjunath-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html