Re: [PATCH 0/3] OMAP: hwmod: Add hardreset and softreset management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On 9/21/2010 7:03 AM, Paul Walmsley wrote:
Hi Benoît,

I regret the delay -

Considering the job you did on that reset series, you are already forgiven :-)


On Thu, 5 Aug 2010, Benoit Cousson wrote:

Here are a reset management series.

- The first patch will be removed as soon as we will have the proper
   OMAP4 support for the prm_xxx accessors.
- The second one is adding hardreset support in order to allow
   syslink driver to manage properly the DSP and IPU processor
   reset.
- The last one is forcing a sofreset after the first init.
   Some IP might require sofreset after each wakeup
   from power domain OFF mode. That still needs to be confirm.

I've reviewed these patches and made a few changes.  The PRM register
twiddling has been moved out into a prm44xx.c file.  I also added OMAP2/3
hardreset support, based on your code.  Could you take a quick look at the
updated series (in subsequent E-mails, or the git branch below) and let me
know if you are okay with it?  I took some liberties in preserving your
changelogs and Signed-off-by's across the changes, so please let me know
if you'd like any changes in that regard.

That's really good. The low level reset does indeed belong to PRM more than the hwmod core code. Thanks for the OMAP2/3 stuff as well, IVA people were starting to ping me for that support.

I've just rebased my OMAP4 hwmods series on top on this one, and it work fine.

Are you targeting that series for 2.6.37?
I have a couple of patches on top of that code that will fix the softreset with optional clocks. This code is fixing the GPIO reset issue that I observed in the past.

I'll send you that soon.

Thanks,
Benoit

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux