> -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Tuesday, September 21, 2010 1:36 PM > To: Nayak, Rajendra > Cc: linux-omap@xxxxxxxxxxxxxxx; Kevin Hilman > Subject: RE: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, > 2430 > > On Tue, 21 Sep 2010, Paul Walmsley wrote: > > > My original comment was somewhat inaccurate. Looking again at the 2430 > > TRM, it looks like the idlest_reg_id is correct, but that the prcm_reg_id > > is not quite correct, at least for the FCLKEN register - not currently > > used by hwmod. We may have to add a workaround flag for the 2430 I2CHS > > case. > > > > I can see why this didn't cause a problem in your testing. The clock > > framework writes to the correct FCLKEN bit, and the hwmod code currently > > doesn't touch the FCLKEN bit. And then the hwmod code checks the > > correct IDLEST bit. > > > > It may be that the clock framework is also buggy for the 2430 I2CHS case - > > that code will probably write to CM_ICLKEN2_CORE for 2430 I2CHS, but it > > should write to CM_ICLKEN1_CORE. sigh... > > Just double-checked the clock code and data - it looks like the clock code > is doing the right thing for 2430 I2CHS: it uses CM_ICLKEN1_CORE, > CM_FCLKEN2_CORE, and CM_IDLEST1_CORE, despite the commit log comments on > 3dc2197579089c5b74c7fba666c8ccf1a449afb4, which are wrong. > > So, that issue that I raised was a false alarm. But it would be good if > you could drop a comment at the top of the two 2430 I2CHS hwmod > structures, and simply note that the CM_FCLKEN* registers for those IP > blocks don't follow the usual pattern. That way, that knowledge won't be > lost completely once the IDLEST handling is removed from the clock > framework, which we'll do as soon as the I2C hwmod code is merged. Sure, will add a note on this. > > Sorry about the confusion, > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
