> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, September 17, 2010 9:02 PM > To: Cousson, Benoit > Cc: G, Manjunath Kondaiah; linux-omap@xxxxxxxxxxxxxxx; > Shilimkar, Santosh > Subject: Re: [PATCH v2 09/11] OMAP: DMA: Implement generic > errata handling > > "Cousson, Benoit" <b-cousson@xxxxxx> writes: > > [...] > > >>>>> If you cannot do that, you will need to add an > omap_device API as > >>>>> well. > >>>> > >>>> There is already one such API exists in hwmod layer for handling > >>>> this type of errata(omap_hwmod_set_slave_idlemode in > omap_hwmod.c). > >>>> Above proposal is based on similar implementation. > >>> > >>> Maybe, but this is not enough. In both case you should not use > >>> directly this API from the driver, so if you want to use > that kind > >>> of approach, you will need the omap_device layer as well. > >> > >> Does that mean, extending omap device layer for modifying > sysconfig? > > > > Yes, > > > > Just to re-iterate Benoit's point: > > Driver's should not have any knowledge of omap_hwmods. All > the interaction with hwmods is done via the omap_device layer. > > So, if it is decide that you need a new API for this > sysconfig change, you have to add it to *both* the hwmod > layer and the omap_device layer. > > As with all the other functions, driver calls omap_device, > and omap_device calls omap_hwmod as needed. Ok. Agreed. -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
