>>-----Original Message----- >>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >>Sent: Thursday, September 16, 2010 10:46 PM >>To: Gopinath, Thara >>Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >>Subject: Re: [PATCH 2/4] OMAP: OPP: twl/tps: Introduce TWL/TPS-specific code >> >>"Gopinath, Thara" <thara@xxxxxx> writes: >> >>[...] >> >>>>>From: Paul Walmsley <paul@xxxxxxxxx> >>>>> >>>>>The OPP layer code should be independent of the PMIC, >>>>>introduce the TWL/TPS-specific code out to its own file. >>> >>> Hello Kevin, >>> >>> I have been using this code for a while now. I really do not think wee >>> need a separate file for implementing the vsel to voltage in (uV) and >>> vice versa formulas. Today only voltage layer is interested in these >>> conversions. Voltage layer has a structure that can be populated with >>> the information required from the PMIC. We only need to add two more >>> function pointers to this structure. This info can then be passed from >>> the actual PMIC driver file. This will make it much more simpler for >>> OMAP4 where we have different formulas between different revisions of >>> PMIC. Also in the omap voltage code we will no longer have to hard >>> code omap_twl_vsel_to_uv and omap_twl_uv_to_vsel. >> >>Feel free to post an RFC series for what you're proposing. >> >>IMHO, even the voltage layer should not care about these conversions. >>The voltage layer should care about voltages, and the PMIC layer should >>handle these conversions. IOW, this stuff is best abstracted in the >>PMIC code, or board- or SoC-specific hooks that can be registered with >>the PMIC. >> >>> So please consider dropping this patch from this series. >> >>If you pick this up as part of your voltage series (or more likely as a >>pre-requisite of your voltage series) we can surely drop it from this >>series, at it doesn't really belong with the OPP series. Hello Kevin/Nishant My suggestion is introduce two new APIs in drivers/twl-core.c. Then once voltage layer support is added call into an API provided by voltage layer to register two APIs. If both Nishant and you are ok with this I will post this change as par of my voltage and smartreflex series. Regards Thara -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
