Re: [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* G, Manjunath Kondaiah <manjugk@xxxxxx> [100826 13:50]:
> From: Manjunatha GK <manjugk@xxxxxx>
> 
> This patch fixes miscellaneous sparse warnings in mach-omap2.
> 
> arch/arm/mach-omap2/board-am3517evm.c:141:17: warning: Initializer entry defined twice
> arch/arm/mach-omap2/board-am3517evm.c:142:18:   also defined here
> 
> arch/arm/mach-omap2/irq.c:50:35: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Manjunatha GK <manjugk@xxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Nishanth Menon <nm@xxxxxx>
> ---
>  arch/arm/mach-omap2/board-am3517evm.c |    1 -
>  arch/arm/mach-omap2/irq.c             |    2 +-
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c
> index ae22ea8..b091741 100644
> --- a/arch/arm/mach-omap2/board-am3517evm.c
> +++ b/arch/arm/mach-omap2/board-am3517evm.c
> @@ -139,7 +139,6 @@ static void am3517_evm_ethernet_init(struct emac_platform_data *pdata)
>  static struct i2c_board_info __initdata am3517evm_i2c1_boardinfo[] = {
>  	{
>  		I2C_BOARD_INFO("s35390a", 0x30),
> -		.type		= "s35390a",
>  	},
>  };

OK, I2C_BOARD_INFO sets it too.
  
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 26aeef5..02fd942 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -47,7 +47,7 @@ static struct omap_irq_bank {
>  } __attribute__ ((aligned(4))) irq_banks[] = {
>  	{
>  		/* MPU INTC */
> -		.base_reg	= 0,
> +		.base_reg	= (void __iomem *)0,
>  		.nr_irqs	= 96,
>  	},
>  };

The base_reg line you can remove, the static data area gets zeroed
during init.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux