"Gopinath, Thara" <thara@xxxxxx> writes: [...] >>>> + * omap_voltage_add_userreq : API to keep track of various requests to >>>> + * scale the VDD and returns the best possible >>>> + * voltage the VDD can be put to. >>>> + * @volt_domain: pointer to the voltage domain. >>>> + * @dev : the device pointer. >>>> + * @volt : the voltage which is requested by the device. >>>> + * >>>> + * This API is to be called before the actual voltage scaling is >>>> + * done to determine what is the best possible voltage the VDD can >>>> + * be put to. This API adds the device <dev> in the user list of the >>>> + * vdd <volt_domain> with <volt> as the requested voltage. The user list >>>> + * is a plist with the priority element absolute voltage values. >>>> + * The API then finds the maximum of all the requested voltages for >>>> + * the VDD and returns it back through <volt> pointer itself. >>>> + * Returns error value in case of any errors. >>>> + */ >>>> +int omap_voltage_add_userreq(struct voltagedomain *voltdm, struct device *dev, >>>> + unsigned long *volt) >>> >>>How about just omap_voltage_add_request() >>> >>>Also, do we need both voltdm and dev? With your other patches, can't we >>>look up the voltm based on dev? Or, is there a need for a device to add >>>a request in a voltage domain other than the one to which it belongs? >>> >>>Also, how does one remove a voltage request? > > Hello Kevin, > > I could rename this API to what you have suggested. Yes we do need voltdm and dev. > Let us say I have three devices in a voltdm and I need to maintain a request for each > of these devices. OK, thanks for clarifying. > When a omap_device_set_rate API is called by the device to lower its rate the voltage > request will automatically get lowered. OK, but what about removing a request when a device no longer has any voltage constraints. [...] Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
