On Wed, Sep 15, 2010 at 11:07 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Wed, Sep 15, 2010 at 04:28:57PM -0500, Steve Sakoman wrote: >> >> On Wed, Sep 15, 2010 at 9:29 AM, Anti Sullin <anti.sullin@xxxxxxxxxxxxxx> >> wrote: >>> >>> I was not getting OTG USB vbus/id pin change interrupts on Gumstix Overo >>> and the reason was a mis-configured irq. I added some more checks to >>> avoid >>> having a non-bootable kernel on boards with bootloaders that have wrong >>> pinmux. >>> The changes of twl4030 should be tested on other boards too. >>> >>> --- >>> Gumstix Overo has TPS65950 (TWL4030) IRQ1 connected to GPIO112. >> >> I don't think that this change should be made. >> >>> From what I understand from my discussions with Gumstix, early >> >> versions of the Overo COM used GPIO112 as indicated above. >> >> However all fab revisions >=2516 use GPIO0, so the code is correct for >> current and future versions of Overo COMs (as is the bootloader >> pinmuxing). >> >> In fact, future versions of Overo will use GPIO112 for a revision ID. >> >> Not an ideal situation, but I think we should leave things as they are >> since it matches current and future production. >> >> People with older boards will certainly need to use this patch to get >> vbus/id interrupts. > > it would be better to get all boards working. Can't you use > ATAG_REVISION or system_rev to differentiate the board revisions and > change gpio number accordingly ?? Agreed. Gumstix doesn't provide an easy way of determining the layout revision via software (the boards are marked with the rev number, but that doesn't do much good!). I'm investigating methods to figure this out, but haven't yet found anything reliable. When I do I'll post a patch. Steve -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
