Re: [PATCH v2 1/2] Revert "OMAP: omap_device: add omap_device_is_valid()"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 14 Sep 2010, Kevin Hilman wrote:

> From: Kevin Hilman <khilman@xxxxxx>
> 
> This reverts commit 0007122ad85cc36b1c18c0b59344093ca210d206.
> 
> The dereference method of checking for a valid omap_device when
> wrapping a platform_device is rather unsafe and dangerous.
> 
> Instead, a better way of checking for a valid omap-device is
> to use a common parent device for all omap_devices, then a check
> can simply be made using the device parent.  The only user of this
> API was the initial version of the runtime PM core for OMAP.  This
> has now been switched to check device parent, so there are no more
> users of this API.
> 
> Signed-off-by: Kevin Hilman <khilman@xxxxxx>

Agreed, this is a much better approach.

Acked-by: Paul Walmsley <paul@xxxxxxxxx>


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux