> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, September 14, 2010 11:35 PM > To: Varadarajan, Charulatha > Cc: tony@xxxxxxxxxxx; wim@xxxxxxxxx; linux-watchdog@xxxxxxxxxxxxxxx; > paul@xxxxxxxxx; Cousson, Benoit; Nayak, Rajendra; Basak, Partha; linux- > omap@xxxxxxxxxxxxxxx > Subject: Re: [v4 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW > APIs > > "Varadarajan, Charulatha" <charu@xxxxxx> writes: > > > Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() > > for enabling/disabling the clocks, sysconfig settings instead of using > > clock FW APIs. > > > > Signed-off-by: Charulatha V <charu@xxxxxx> > > Looks mostly good, one minor comment > > [...] > > > +static int wdt_runtime_suspend(struct device *dev) > > +{ > > + return 0; > > +} > > + > > +static int wdt_runtime_resume(struct device *dev) > > +{ > > + return 0; > > +} > > + > > +static const struct dev_pm_ops gpio_pm_ops = { > > + .runtime_suspend = wdt_runtime_suspend, > > + .runtime_resume = wdt_runtime_resume, > > +}; > > + > > This isn't needed anymore for 2.6.37, a fix for the return values in the > generic runtime PM calls has been queued for 2.6.37[1] Thanks. I've removed runtime_suspend/resume hooks from watchdog driver and sent the next version of the series. > > Kevin > > [1] https://lists.linux-foundation.org/pipermail/linux-pm/2010- > September/028466.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
