> -----Original Message----- > From: Gadiyar, Anand > Sent: Monday, September 13, 2010 9:58 PM > To: Shilimkar, Santosh > Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; > khilman@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/7] omap4: l2x0: Fix init parameter for ES2.0 > > On Thu, Sep 9, 2010 at 4:53 PM, Santosh Shilimkar > <santosh.shilimkar@xxxxxx> wrote: > > On ES2.0 the L2 cache init parameter ineeds to be changed to take > > care of cache size. The cache size is 1MB on ES2.0 vs 512KB on ES1.0 > > > > This patch fixes the init parameter to update the same using > > dynamic cpu version check > > > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > --- > > arch/arm/mach-omap2/omap4-common.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach- > omap2/omap4-common.c > > index 13dc979..2b32229 100644 > > --- a/arch/arm/mach-omap2/omap4-common.c > > +++ b/arch/arm/mach-omap2/omap4-common.c > > @@ -64,7 +64,10 @@ static int __init omap_l2_cache_init(void) > > * 32KB way size, 16-way associativity, > > * parity disabled > > */ > > - l2x0_init(l2cache_base, 0x0e050000, 0xc0000fff); > > + if (omap_rev() == OMAP4430_REV_ES2_0) > > + l2x0_init(l2cache_base, 0x0e070000, 0xc0000fff); > > + else > > + l2x0_init(l2cache_base, 0x0e050000, 0xc0000fff); > > > It's probably better to invert this check - you need 512 kB on ES1 > alone, but ES2 and newer will need more. You need the exception only > for the ES1 case. > > (else you will end up patching this section again with newer revisions as > well). > Good point -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
