> -----Original Message----- > From: Cousson, Benoit > Sent: Thursday, September 09, 2010 5:17 PM > To: Balbi, Felipe > Cc: Shilimkar, Santosh; linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; > khilman@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/7] omap4: Temporary fix silicon version detection > > Hi Santosh, > > On 9/9/2010 1:42 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Sep 09, 2010 at 06:23:10AM -0500, Santosh Shilimkar wrote: > >> @@ -308,6 +308,16 @@ static void __init omap4_check_revision(void) > >> hawkeye = (idcode>> 12)& 0xffff; > >> rev = (idcode>> 28)& 0xff; > >> > >> + /* > >> + * FIXME: This patch should be reverted later. > >> + * Few initial ES2.0 samples IDCODE is same as ES1.0 > >> + * Use ARM register to detect the correct ES version > >> + */ > > > > I wonder if it actually doesn't make sense to keep this in tree, the > > overhead is minimum when rev is set correctly and it's safe for the > > initial es2.0 samples which are buggy. > > Yep, I agree with that, if some early ES2 samples are already out there, > we will have no way to control the device upgrade in the future. So we > will still have to support these early buggy devices just in case. > Felipe is suggesting not to add this support where as you want to have this support. Sorry if I haven't understood the comment. Care to clarify Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
