From: "ext Premi, Sanjeev" <premi@xxxxxx> Subject: RE: [PATCH] omap: OMAP_IOMMU not visible in menuconfig Date: Thu, 9 Sep 2010 07:10:05 +0200 >> -----Original Message----- >> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] >> Sent: Thursday, September 09, 2010 10:35 AM >> To: Premi, Sanjeev >> Cc: linux-omap@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig >> >> Hi Sanjeev, >> >> From: ext Sanjeev Premi <premi@xxxxxx> >> Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig >> Date: Wed, 8 Sep 2010 16:51:21 +0200 >> >> > The menu option to select CONFIG_OMAP_IOMMU >> > was not visible in the menuconfig due to missing >> > description. >> >> There's no point to make OMAP_IOMMU visible since this is a kind of >> feature used by other device implicitly. OMAP_IOMMU on menu >> might confuse >> users at kernel menuconfig. Instead this should be automatically >> selected by its clients when it is selected. For exmaple, the case >> that DSP or Tesla is selected. There was a discussion about this >> before. > > [sp] You would have noticed that there are mnay OMAP3 variants and > some of them are ARM only - detection being runtime, not compile > time. > > All these processors share same defconfig. Setting dependency correctly could solve this? Modified drivers/staging/tidspbridge/Kconfig diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig index 93de4f2..ff64d46 100644 --- a/drivers/staging/tidspbridge/Kconfig +++ b/drivers/staging/tidspbridge/Kconfig @@ -6,6 +6,7 @@ menuconfig TIDSPBRIDGE tristate "DSP Bridge driver" depends on ARCH_OMAP3 select OMAP_MBOX_FWK + select OMAP_IOMMU help DSP/BIOS Bridge is designed for platforms that contain a GPP and one or more attached DSPs. The GPP is considered the master or > > Keeping/ maintaining specific defconfigs for each processor will > be too difficult. > > ~sanjeev > >> >> > >> > Signed-off-by: Sanjeev Premi <premi@xxxxxx> >> > --- >> > arch/arm/plat-omap/Kconfig | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig >> > index e39a417..2a114a9 100644 >> > --- a/arch/arm/plat-omap/Kconfig >> > +++ b/arch/arm/plat-omap/Kconfig >> > @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE >> > module parameter). >> > >> > config OMAP_IOMMU >> > - tristate >> > + tristate "OMAP IOMMU support" >> > >> > config OMAP_IOMMU_DEBUG >> > tristate "Export OMAP IOMMU internals in DebugFS" >> > -- >> > 1.6.2.4 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe >> linux-omap" in >> > the body of a message to majordomo@xxxxxxxxxxxxxxx >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
