* David Cross <david.cross@xxxxxxxxxxx> [100908 09:52]: > > > From: Greg KH [mailto:greg@xxxxxxxxx] > > > On Tue, Sep 07, 2010 at 12:26:47PM -0700, David Cross wrote: > > > This patch exports some of the gpmc driver functions in OMAP3. The > purpose behind this patch > > > is to allow device drivers compiled as loadable modules to be interfaced > > to the GPMC. I am > > > hoping that Tony is the correct maintainer and willing to ACK this > change. Please let me know > > > if there are any issues or concerns with this patch. > > > Thanks, > > > David > > > > > > Signed-off-by: David Cross <david.cross@xxxxxxxxxxx> > > > > > > diff -uprN -X linux-next-vanilla/Documentation/dontdiff > linux-next-vanilla/arch/arm/mach-omap2/gpmc.c > linux-next-incl-sdk/arch/arm/mach-omap2/gpmc.c > > > --- linux-next-vanilla/arch/arm/mach-omap2/gpmc.c 2010-08-31 > 19:32:51.000000000 -0700 > > > +++ linux-next-incl-sdk/arch/arm/mach-omap2/gpmc.c 2010-09-01 > 16:10:21.000000000 -0700 > > > @@ -133,6 +133,7 @@ void gpmc_cs_write_reg(int cs, int idx, > > > reg_addr = gpmc_base + GPMC_CS0_OFFSET + (cs * GPMC_CS_SIZE) + idx; > > > __raw_writel(val, reg_addr); > > > } > > > +EXPORT_SYMBOL(gpmc_cs_write_reg); > > > EXPORT_SYMBOL_GPL() perhaps? > > I don't have an issue with that, though I am not sure I understand why we > would want to limit the usage of the function to GPL'd modules. It is > probably Tony's call assuming he is ok with exporting the symbol. Exporting these is not a good idea, it should be done in the platform init code like I replied in another message. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
