On Mon, 2010-09-06 at 11:06 +0100, Russell King - ARM Linux wrote: > On Mon, Sep 06, 2010 at 10:38:30AM +0100, Catalin Marinas wrote: > > On Mon, 2010-09-06 at 10:34 +0100, Russell King - ARM Linux wrote: > > > On Mon, Sep 06, 2010 at 10:28:53AM +0100, Catalin Marinas wrote: > > > > I haven't followed your patches closely but can we restrict the ARMv6 > > > > SMP/UP support to only those cores that have TEX remapping (most of them > > > > probably)? > > > > > > We don't support TEX remapping on ARMv6. > > > > I know but it's easy to enable if useful for the SMP/UP v6/v7 > > combination (with some restrictions). > > It'll make proc-v6.S much more complicated than it already is, requiring > it to carry both the non-remap and remapping code selected via an ifdef. > > Is it worth it? For the sake of one conditional in mmu.c, I don't think > so - and the view is that using TEX remapping to get rid of the shared > bit is a horrible hack anyway. > > In any case, it's unnecessary. We can use my word-replacement to modify > a variable to indicate whether we're running on SMP or not, and so have > the test for SMP-on-UP in just one place. Like this: It looks fine to me. Thanks. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html