On Thu, Sep 02, 2010 at 11:13:17AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [100902 10:54]: > > On Thu, Sep 02, 2010 at 10:21:33AM -0700, Tony Lindgren wrote: > > > * Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [100902 09:50]: > > > > On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote: > > > > > diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S > > > > > index 07fc660..51a063d 100644 > > > > > --- a/arch/arm/mm/proc-v7.S > > > > > +++ b/arch/arm/mm/proc-v7.S > > > > > @@ -191,7 +191,8 @@ __v7_setup: > > > > > UP(mov r0, #(1 << 6)) @ fake it for UP > > > > > > > > If it's UP, we set r0 to 1 << 6, which... > > > > > > > > > tst r0, #(1 << 6) @ SMP/nAMP mode enabled? > > > > > > > > means this test produces a non-zero result. > > > > > > > > > orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and > > > > > - mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting > > > > > > > > And therefore these instructions will not be executed. > > > > > > AFAIK these bits are different for Cortex-A8 and A9, bit 6 is IBE on A8. > > > > So what? > > Ah right, sorry I should have looked more carefully. You're right, this patch > is no longer needed either. Thanks - I was wondering whether I was missing something. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html