RE: [PATCH 04/20] Create platform_driver for each DSS HW IP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] 
> Sent: Friday, August 27, 2010 5:22 AM
> To: Guruswamy, Senthilvadivu
> Cc: linux-omap@xxxxxxxxxxxxxxx; tomi.valkeinen@xxxxxxxxx; 
> paul@xxxxxxxxx
> Subject: Re: [PATCH 04/20] Create platform_driver for each DSS HW IP
> 
> Guruswamy Senthilvadivu <svadivu@xxxxxx> writes:
> 
> > From: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> >
> > Platform driver of DSS HW IP are to be registered in sequence before
> > the omapdss platform driver is registered.
> >
> > Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> > ---
> >  drivers/video/omap2/dss/core.c |  121 
> ++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 121 insertions(+), 0 deletions(-)
> >
> >  
> > +/* DSS HW IP initialisation */
> > +static int omap_dsshw_probe(struct platform_device *pdev)
> > +{
> > +	return 0;
> > +}
> > +
> > +static int omap_dsshw_remove(struct platform_device *pdev)
> > +{
> > +	return 0;
> > +}
> 
> It's not customary to create dummy, empty functions in one patch and
> then fill them in later.  In this case, you create them here, 
> move them
> in PATCH 05/20, then fill them in later.
> 
> It would be easier to review if you created the platform_drivers when
> needed.
> 
> Anyways, I'm not crazy about this approach, but Tomi can decide.
> 
[Senthil]  As I mentioned in my TODO list, I will try to move all the probe/remove to
the corresponding driver files as directly in my next version.
> 
> > +/* DISPC HW IP initialisation */
> > +static int omap_dispchw_probe(struct platform_device *pdev)
> > +{
> > +	return 0;
> > +}

> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux